Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some SonarCloud issues #1345

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix some SonarCloud issues #1345

merged 1 commit into from
Nov 13, 2024

Conversation

ewan-escience
Copy link
Collaborator

Fix some SonarCloud issues

Changes proposed in this pull request

  • Fix some low-effort SonarCloud issues
  • Add a logger to the authentication module

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
  • The build should succeed without errors
  • Sign in as admin and user, through various providers, this should still work

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

sonarcloud bot commented Nov 13, 2024

@ewan-escience ewan-escience merged commit 70029ae into main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants